Fix test_max_model_len in tests/entrypoints/llm/test_generate.py #19451
Conversation
houseroad
requested review from
DarkLight1337,
aarnphm,
robertgshaw2-redhat and
simon-mo
as code owners
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @houseroad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a test failure in the LLM generation tests by adjusting the assertion logic for checking the total number of tokens against the maximum model length. The change ensures the test correctly validates the token limit even when generation terminates early.
Highlights
- Test Fix: Corrected the assertion logic in the
test_max_model_lenfunction. - Assertion Logic: Updated the assertion from
==to<=to correctly handle cases where token generation might stop before reaching the exactmax_model_len.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request correctly modifies the assertion in the test_max_model_len test case. Changing the condition from == max_model_len to <= max_model_len makes the test more robust by accurately reflecting that the total number of tokens can be less than max_model_len if generation terminates early due to reasons like EOS token generation. The change is sound. I've suggested adding an inline comment to the test to clarify this behavior for future maintainability.
Signed-off-by: Lu Fang <lufang@fb.com>
houseroad
force-pushed
the
fix_test_generate
branch
from
9b0503e to
1bd02a9
Compare
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
mgoin
added
ready
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
3 participants
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
The original test didn't consider cases that we exit earlier. So we should relax the test to <= from ==
Some failing example: https://buildkite.com/vllm/fastcheck/builds/26960#01975b5c-44fe-43b0-88b4-272b80a8263f
Test Plan
pytest tests/entrypoints/llm/test_generate.py
Test Result
The test passed.
(Optional) Documentation Update
N/A